Initialize data in form before the checks for the blocks and `block…

…s_layout` are done (#5445)

.github/workflows/changelog.yml

@@ -47,7 +47,7 @@ jobs:
           BASE_BRANCH: ${{ github.base_ref }}
 
       - name: Registry changelog check
-        if: steps.filter.outputs.volto == 'true'
+        if: steps.filter.outputs.registry == 'true'
         run: |
           # Fetch the pull request' base branch so towncrier will be able to
           # compare the current branch with the base branch.

news/5445.bugfix

@@ -0,0 +1 @@
+Initialize data in form before the checks for the `blocks` and `blocks_layout` are done This fix an edge case when the data from the server content is empty, then the fields are populated, but the initialized data is snapshot after the check (and amendments) are done. @sneridagh

package.json

@@ -28,7 +28,7 @@
     "eslint-plugin-prettier": "5.0.0",
     "eslint-plugin-react": "7.33.2",
     "husky": "^8.0.3",
-    "lint-staged": "^15.1.0",
+    "lint-staged": "15.0.2",
     "prettier": "3.0.3",
     "tsconfig": "workspace:*",
     "turbo": "latest",

packages/volto/news/5445.bugfix

@@ -0,0 +1 @@
+Initialize data in form before the checks for the `blocks` and `blocks_layout` are done This fix an edge case when the data from the server content is empty, then the fields are populated, but the initialized data is snapshot after the check (and amendments) are done. @sneridagh

packages/volto/src/components/manage/Form/Form.jsx

@@ -148,7 +148,10 @@ class Form extends Component {
         ...formData,
       };
     }
-    // defaults for block editor; should be moved to schema on server side
+
+    // We initialize the formData snapshot in here, before the initial data checks
+    const initialFormData = cloneDeep(formData);
+
     // Adding fallback in case the fields are empty, so we are sure that the edit form
     // shows at least the default blocks
     if (
@@ -200,7 +203,7 @@ class Form extends Component {
 
     this.state = {
       formData,
-      initialFormData: cloneDeep(formData),
+      initialFormData,
       errors: {},
       selected: selectedBlock,
       multiSelected: [],