Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure CMFPlone's permissions are loaded #1827

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Make sure CMFPlone's permissions are loaded #1827

merged 2 commits into from
Oct 23, 2024

Conversation

davisagli
Copy link
Member

@davisagli davisagli commented Oct 23, 2024

This fixes a zope.interface.interfaces.ComponentLookupError: (<InterfaceClass zope.security.interfaces.IPermission>, 'Products.CMFPlone.ManagePortalAliases') which can happen depending on the order in which packages load.


📚 Documentation preview 📚: https://plonerestapi--1827.org.readthedocs.build/

@mister-roboto
Copy link

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 203cfb3 into main Oct 23, 2024
21 of 25 checks passed
@davisagli davisagli deleted the fix-zcml branch October 23, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants