fix show_excluded_items in @navigation api #1816
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
In Plone 5.2 test is broken with and without the fix. |
|
@jenkins-plone-org please run jobs |
| response = self.api_session.get( | ||
| "/folder/@navigation", params={"expand.navigation.depth": 2} | ||
| ) | ||
| self.assertNotIn( |
There was a problem hiding this comment.
Is settings.show_excluded_items==True at this point? That could explain the test failure.
There was a problem hiding this comment.
@mamico I noticed that there are differences between the the Python 3.8/Plone 5.2 and all other runs. There are two extra lines, excluding any deprecation warnings, between the test setup and test results: https://github.com/plone/plone.restapi/actions/runs/10954244520/job/30415848888?pr=1816#step:10:216
*** Relations rebuild. flush: False
*** Relations rebuild. flush: TruePerhaps that is a clue?
Also do we care about Plone 5.2/Python 3.8 for this bugfix? I don't think it is a security issue, but a maintenance fix, and Plone 5.2 is out of maintenance support.
There was a problem hiding this comment.
@stevepiercy probably your first suggestion is the right one. It seems that Plone 5.2 and Plone 6.0 have different defaults for show_ecluded_items (?). Now I explicitly set it in the test. I am waiting for the results of the CI...
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
|
@jenkins-plone-org please run jobs |
The
show_ecluded_itemssetting does not work for the@navigationAPI due to an incorrect condition.📚 Documentation preview 📚: https://plonerestapi--1816.org.readthedocs.build/