Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pam layer in pam services #1723

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix: use pam layer in pam services #1723

merged 3 commits into from
Oct 16, 2023

Conversation

mamico
Copy link
Member

@mamico mamico commented Oct 15, 2023

This fix limits the use of multilingual services only if multilingual is actually installed, not only if it is present in the 'eggs' (because in the new distribution of Plone, plone.app.multilingual is always present).

@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 1744dfe
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/652c70ee521b7f00089e2e8b

@mister-roboto
Copy link

@mamico thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tisto tisto merged commit 1eb8e44 into main Oct 16, 2023
18 checks passed
@tisto tisto deleted the pam_layer branch October 16, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants