Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for python2 in branch 7.x.x #1721

Merged
merged 22 commits into from
Oct 14, 2023
Merged

Fix tests for python2 in branch 7.x.x #1721

merged 22 commits into from
Oct 14, 2023

Conversation

erral
Copy link
Member

@erral erral commented Oct 7, 2023

No description provided.

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@tisto tisto self-requested a review October 9, 2023 21:41
Copy link
Member

@tisto tisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral PR LGTM. You just need to update the docs to fix the CI failure as far as I can see...

@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@davisagli davisagli force-pushed the erral-2.7-tests.7.x.x branch from c493bf2 to c85ff9a Compare October 14, 2023 20:23
@davisagli davisagli merged commit 3bdb4f5 into 7.x.x Oct 14, 2023
8 checks passed
@davisagli davisagli deleted the erral-2.7-tests.7.x.x branch October 14, 2023 20:36
@davisagli
Copy link
Member

@erral thanks!

@erral
Copy link
Member Author

erral commented Oct 15, 2023

Thanks for looking at the docs failures!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants