Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex asserts #1719

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Fix regex asserts #1719

merged 3 commits into from
Oct 9, 2023

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Oct 5, 2023

That's part of plone/Products.CMFPlone#3852 effort

@netlify
Copy link

netlify bot commented Oct 5, 2023 •
edited
Loading

✅ Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 24f9439
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/652165a6341e5600089c3116

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada requested review from pbauer and jensens October 5, 2023 17:22
jensens
jensens approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall we can merge as is, OTOH readability increases with @davisagli suggestion.

@gforcada gforcada force-pushed the fix-regex-asserts branch 2 times, most recently from 205ea7f to 7ed357f Compare October 7, 2023 08:25
@gforcada
fix(py3.12): deprecated methods
666c240 
I used the approach suggested on https://stackoverflow.com/questions/20050913

This makes plone.restapi tests pass on Python 3.12.
@gforcada
Add news entry
4dfa9e9
davisagli
davisagli approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved now as long as the tests are green

@gforcada
Copy link
Member Author

gforcada commented Oct 8, 2023

@jenkins-plone-org please run jobs

@tisto tisto merged commit 063e4e0 into main Oct 9, 2023
18 checks passed
@tisto tisto deleted the fix-regex-asserts branch October 9, 2023 21:39
@tisto
Copy link
Member

tisto commented Oct 9, 2023

@gforcada thanks for working on this Gil!

@gforcada gforcada mentioned this pull request Oct 14, 2023
Closed
10 tasks
tisto added a commit that referenced this pull request Oct 18, 2023
@tisto
Fix changelog for #1719
d68bb76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees left review comments

@jensens jensens jensens approved these changes

@davisagli davisagli davisagli approved these changes

@pbauer pbauer Awaiting requested review from pbauer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gforcada @mister-roboto @tisto @davisagli @jensens @mauritsvanrees