Treat sub-items like items in @linkintegrity

[jaroel]

[X] Needs plone/plone.app.linkintegrity#95

Breaking: this changes the shape of an endpoint.

[netlify]

✅ Deploy Preview for plone-restapi canceled.

Name	Link
🔨 Latest commit	a5ebc3b
🔍 Latest deploy log	https://app.netlify.com/sites/plone-restapi/deploys/652f922dc24b320008c3362d

[sneridagh]

LGTM - Except for the breaking, I know this sucks, but I'd rather try not to trigger a breaking change. @tisto your call.

[tisto]

@sneridagh if we have a breaking change, we have a breaking change. No harm in that. We will just do a plone.restapi 10 release...

If you are using semver you shouldn't be afraid to bump a major version :)

[tisto]

@jaroel I did not really look into the code. Question up front: can we write the plone.restapi code in a way that it will still work if plone.app.querystring is not the latest version? I am ok with a breaking change release of plone.restapi. Though, I wouldn't want to introduce a hard dependency on a plone.app.querystring version if possible.

[jaroel]

@tisto the shape of plone.app.linkintegrity's data has not changed, not a problem. You'll see some duplicate entries in the modal, but that's what the new stuff is for.

[tisto]

@jenkins-plone-org please run jobs

[davisagli]

@jaroel One question, and I think you need to update the sample response that goes in the docs, but yeah, that looks more promising.

[jaroel]

@jaroel One question, and I think you need to update the sample response that goes in the docs, but yeah, that looks more promising.

Afaict the request and response haven't changed?

[davisagli]

Afaict the request and response haven't changed?

@jaroel Uh right, I was thinking wrong.

Looks good to me now.

[tisto]

@jenkins-plone-org please run jobs

[tisto]

@jaroel p.a.linkintegrity has been release with a fix. Do you want to amend this PR before merging and releasing?

[jaroel]

@jaroel p.a.linkintegrity has been release with a fix. Do you want to amend this PR before merging and releasing?

@tisto Could you release plone.app.linkintegrity 3.x too (with the backport)? Then I can remove the skipUnless. We can also land this work first and then change after. Dealer's choice.

[tisto]

@jaroel here you go:

https://pypi.org/project/plone.app.linkintegrity/3.6.2/

[jaroel]

@jenkins-plone-org please run jobs

[stevepiercy]

Clean up change notes for reStructuredText syntax and rendering of GitHub username links.

[stevepiercy]

Thank you!

[tisto]

@jenkins-plone-org please run jobs