Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated token parameter from vocabularies endpoint #1701

Closed
wants to merge 2 commits into from

Conversation

tisto
Copy link
Member

@tisto tisto commented Aug 28, 2023

No description provided.

@tisto tisto requested review from davisagli and sneridagh August 28, 2023 22:00
@mister-roboto
Copy link

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 26fc74e
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/650c914b7c9d9c0008cfdb83

@tisto
Copy link
Member Author

tisto commented Aug 28, 2023

@davisagli @sneridagh I removed the deprecated "token" parameter altogether in the PR now. I was wondering if we should return a 422 unprocessable entity (or something else) in case someone passes the "token" paramenter instead of "tokens". The idea would be to fail hard, so people notice it instead of just ignoring it (which might be hard to track).

The downside of this approach is that we have code that we might want to remove in plone.restapi 10 to clean up stuff. Opinions?

@davisagli
Copy link
Member

-1 from me, this breaks volto as it currently uses this endpoint

@tisto tisto closed this Sep 21, 2023
@tisto tisto deleted the fix-1697 branch September 21, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants