Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation remote url #1654

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Navigation remote url #1654

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad2fc6d
Add remoteUrl and @type properties in navigation get request
iFlameing Jun 6, 2023
4393455
remove print
iFlameing Jun 6, 2023
8f12ba7
Merge branch 'master' into navigation-remote-url
avoinea Jun 8, 2023
3005f40
Merge branch 'main' into navigation-remote-url
claudiaifrim Feb 21, 2024
25a3e19
Merge branch 'main' into navigation-remote-url
claudiaifrim Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/plone/restapi/services/navigation/get.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ def navtree(self):
"description": safe_text(brain.Description),
"review_state": json_compatible(brain.review_state),
"use_view_action_in_listings": brain.portal_type in types_using_view,
"remoteUrl": json_compatible(brain.getRemoteUrl),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iFlameing can you elaborate on your use case? Why do we use "remoteURL" and not "remote_url"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto This was related to a feature request from our client (ticket 1840) which was closed as requiring too much effort

"@type":safe_text(brain.portal_type)
}
if "nav_title" in brain and brain.nav_title:
entry.update({"title": brain.nav_title})
Expand Down
Loading