Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex asserts #514

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Fix regex asserts #514

merged 2 commits into from
Oct 14, 2023

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Oct 5, 2023

That's part of plone/Products.CMFPlone#3852 effort

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens
Copy link
Member

jensens commented Oct 6, 2023

Why are there still tests for 5.2? Should we run plone.meta on this before merging here?

@mauritsvanrees
Copy link
Member

Coredev 5.2 uses branch 1.x, so from that point of view it is fine to drop 5.2 support.

@gforcada
Copy link
Member Author

@jensens @mauritsvanrees on #519 I fixed the plone/python versions being tested, so that PRs can actually pass 👍🏾

This one should work now 🍀

@gforcada
Copy link
Member Author

@jenkins-plone-org please run jobs

@gforcada
Copy link
Member Author

@jensens plone/meta is on #509 I will rebase it and there were a few things that needed discussion, or that I was not 100% sure on how to handle them

@gforcada
Copy link
Member Author

The failing 3.12 job is expected, as we are missing some version pins from plone/buildout.coredev#890 which in turn fails on 3.12 because it's missing the fixes here 🥚 🐔

@gforcada
Copy link
Member Author

Merging as it works on 6.0/1 and it is needed for Python 3.12 👍🏾

@gforcada gforcada merged commit 86a2b87 into master Oct 14, 2023
7 checks passed
@gforcada gforcada deleted the fix-regex-asserts branch October 14, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants