-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regex asserts #514
Fix regex asserts #514
Conversation
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Why are there still tests for 5.2? Should we run |
Coredev 5.2 uses branch 1.x, so from that point of view it is fine to drop 5.2 support. |
c5efb3e
to
b26d6e7
Compare
@jensens @mauritsvanrees on #519 I fixed the plone/python versions being tested, so that PRs can actually pass 👍🏾 This one should work now 🍀 |
@jenkins-plone-org please run jobs |
The failing 3.12 job is expected, as we are missing some version pins from plone/buildout.coredev#890 which in turn fails on 3.12 because it's missing the fixes here 🥚 🐔 |
Merging as it works on 6.0/1 and it is needed for Python 3.12 👍🏾 |
That's part of plone/Products.CMFPlone#3852 effort