-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous integration rewrite #1676
Continuous integration rewrite #1676
Conversation
7242f42
to
ba3e0ad
Compare
@gforcada I'm back from vacation. Please let me know if you would like some help with this PR. Thanks for your work on it! |
@stevepiercy hey, welcome back! I hope you enjoyed them! Yes, it would be interesting to know how we can organize this document, and any follow up documents regarding CI. This write up as it is, is a bit of a high level overview of the CI current status: We use Jenkins and GitHub Actions thanks to PR-based development. We should split this into different sections/files probably though (following diataxis):
Would something like align with your ideas as well? 🤔 🍀 |
@gforcada let's focus on the developer audience first. A how-to guide would be helpful. I think the pieces that we need more information include:
There are some places in the docs where some CI stuff is already mentioned, for example, Change log entry and Continuous integration. Links between the content may be useful. |
@stevepiercy thanks for the write up, I will try to work on it piece by piece. Would it be worth creating small PRs so they can be easier to deal with? |
Explain Jenkins.
ba3e0ad
to
eb74510
Compare
Here it is, it's maybe a first draft, I tried to keep it quick and simple so we can expand on it as feedback comes :) Let me know if you want me to expand some sections, give more context, etc. |
- Make statements more concise - Address the reader with "you can do X" instead of passive voice "X is done" - Add pretty inline icons and MyST markup magic - Remove italicization style of `guilabel` elements - Add to index, remove from exclusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gforcada I did a review by editing your contribution as a foundation. Would you please review my changes, particularly for accuracy, and any other suggestions you might make? Thank you!
The failing check is fixed in #1693 and can be ignored. There are two other links that had temporary outages, but are working fine now. |
The failing CI check is a temporary outage of the Plone Community Forum, and can be ignored. |
@stevepiercy wow, so much better! 👑 thanks a lot! I don't see any mistakes, so it should go in as you see fit 😄 |
@gforcada thanks for push. Merging! |
This is my rewrite of the CI section.
I kept it short and a bit basic, without touching too many details, we could probably expand it more but as a first step probably is ok, and specially better than those rules that are no longer applying.
📚 Documentation preview 📚: https://plone6--1676.org.readthedocs.build/