Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration rewrite #1676

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Jul 7, 2024

This is my rewrite of the CI section.

I kept it short and a bit basic, without touching too many details, we could probably expand it more but as a first step probably is ok, and specially better than those rules that are no longer applying.


📚 Documentation preview 📚: https://plone6--1676.org.readthedocs.build/

@gforcada gforcada requested a review from stevepiercy July 7, 2024 17:28
Base automatically changed from integratel-coredev.buildout-2 to 6.0 July 20, 2024 12:31
@gforcada gforcada force-pushed the coredev.buildout-continuous-integration-fixes branch from 7242f42 to ba3e0ad Compare August 4, 2024 05:33
@stevepiercy
Copy link
Contributor

@gforcada I'm back from vacation. Please let me know if you would like some help with this PR. Thanks for your work on it!

@gforcada
Copy link
Member Author

gforcada commented Aug 4, 2024

@stevepiercy hey, welcome back! I hope you enjoyed them!

Yes, it would be interesting to know how we can organize this document, and any follow up documents regarding CI.

This write up as it is, is a bit of a high level overview of the CI current status:

We use Jenkins and GitHub Actions thanks to PR-based development. mr.roboto provides the ink-link between GitHub and Jenkins.

We should split this into different sections/files probably though (following diataxis):

  • a simple how-to guide to explain what you need to do to get your PR tested
  • a tutorial/explanation on how the whole CI is orquestrated and managed
  • not sure if we need a reference, maybe that would be more to document how mr.roboto is internally configured, etc ?

Would something like align with your ideas as well? 🤔 🍀

@stevepiercy
Copy link
Contributor

@gforcada let's focus on the developer audience first. A how-to guide would be helpful. I think the pieces that we need more information include:

  • Jenkins
    • What does it do?
    • How to run it through a GitHub comment.
    • How to run it through the Jenkins site.
    • How to diagnose a failure.
    • What to do when it fails.
    • How to retry a failed Jenkins run.
  • mr.roboto
    • What does it do?
  • @mister-roboto for no PCA or email mismatch between PCA and GitHub. (I think the current message only says there is no PCA, which confuses those people who have returned the PCA but their emails don't match, but that's a separate issue.)
  • Other Plone core CI (Optional. Perhaps just a mention with links to relevant examples or repos, as each repo has its own implementation.)

There are some places in the docs where some CI stuff is already mentioned, for example, Change log entry and Continuous integration. Links between the content may be useful.

@gforcada
Copy link
Member Author

@stevepiercy thanks for the write up, I will try to work on it piece by piece. Would it be worth creating small PRs so they can be easier to deal with?

@gforcada gforcada force-pushed the coredev.buildout-continuous-integration-fixes branch from ba3e0ad to eb74510 Compare August 20, 2024 07:27
@gforcada
Copy link
Member Author

Here it is, it's maybe a first draft, I tried to keep it quick and simple so we can expand on it as feedback comes :)

Let me know if you want me to expand some sections, give more context, etc.

- Make statements more concise
- Address the reader with "you can do X" instead of passive voice "X is done"
- Add pretty inline icons and MyST markup magic
- Remove italicization style of `guilabel` elements
- Add to index, remove from exclusion
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforcada I did a review by editing your contribution as a foundation. Would you please review my changes, particularly for accuracy, and any other suggestions you might make? Thank you!

@stevepiercy
Copy link
Contributor

The failing check is fixed in #1693 and can be ignored. There are two other links that had temporary outages, but are working fine now.

@stevepiercy
Copy link
Contributor

The failing CI check is a temporary outage of the Plone Community Forum, and can be ignored.

@gforcada
Copy link
Member Author

@stevepiercy wow, so much better! 👑 thanks a lot!

I don't see any mistakes, so it should go in as you see fit 😄

@stevepiercy
Copy link
Contributor

@gforcada thanks for push. Merging!

@stevepiercy stevepiercy merged commit e9d9be6 into 6.0 Aug 21, 2024
2 of 3 checks passed
@stevepiercy stevepiercy deleted the coredev.buildout-continuous-integration-fixes branch August 21, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants