Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Helpers #754

Open
wants to merge 116 commits into
base: master
Choose a base branch
from
Open

WIP: Helpers #754

wants to merge 116 commits into from

Conversation

djay
Copy link
Contributor

@djay djay commented Sep 5, 2016 •
edited
Loading

Fixes this issue - #618

  • make field helpers specific to certain field types
  • fix enabling behaviours
  • fix widget for selecting other databases to import from
  • make import from other dbs work
  • fix datagrids from new changes to widget
  • be smart about how generated code is combined. e.g. validations vs hidewhens vs others.
  • decide on final name. helpers? macros? behaviours? wizards?
  • need to generate ids for each helper instance and store them so code can be updated separately. Will mean a helper won't be wiped should its form go missing.
  • fix widget for selecting helper to add (should be autocomplete. hopefully give description of each)
  • detect if field to override is a formula.
  • make helpers work on add form
  • fix close button on datagrid popup

Future

  • ootb helper db for basic helpers.
  • consider switching to a select2 keyword widget. except need a reedit button and place to store data.

djay and others added 25 commits July 11, 2016 16:55
@djay
initial checkin of fields being inserted visually into tinymce
fde0b3f
@djay
Merge remote-tracking branch 'origin/missing-tinymce-buttons' into ti…
35d23b7 
…nymcevisualfields
@djay
store layout without example widgets
28ee077
@djay
fix formatting of html on save stripping html widgets
5037fb1
@djay
cache,label and hidewhen should now work as noneditable dragable elem…
fce2bb0 
…ents
@djay
Merge branch 'master' into tinymcevisualfields
3b73857
@djay
allow adding a field without typing the id first
ddd99ff
@djay
fix up popups for hidewhen and actions
b629fef
@djay
clean up css for visual elements in tinymce
bc57a05
@djay
dnd subforms now work
d912880
@djay
handle inserting dnd datagrids using very basic progressive table. Ca…
5b49943 
…n't yet disable tinymces table controls.
@djay
fix bug in creating empty form
b0661e8
@djay
fix for display fields with no content
af4fc27
@djay
initial version of helpers
ec2fa66
Merge branch 'dynamic-display-fields' into multipage-p2
9249554
Include pyquery
2f636f0
Attempt to merge multipage into Plomino 2
203086e
Fix Flake version and add a resources directory
ede6dc2
Merge tinymcevisualfields
5c3b8bd
@djay
helpers is now a behaviour.
7f17ca1
@instification
Fix syntax error
dc81085
@djay
automatically detect and list helpers in the same db
c6ae104
@djay
try to improve import/export so it uses datamanagers and handles beha…
775f530 
…viours
@djay
Merge remote-tracking branch 'origin/master' into helpers_ide
862c3f6
@djay
titles in datagrid for helpers and hack to fix the import
6d1a8e2
@ebrehault
Copy link
Member

Great work!
Implementation looks good.
(Tell me when you consider it mergeable)

Daniel Marks and others added 30 commits September 27, 2016 10:42
Handle nonvisual label code
5720846
Use the right setting for a multiple select2 field
d2b3a33
@ivanteoh
Fix the datetime to check json dict
d9b8a6f
Update plomin-compiled.js with latest datagrids and macros
b271c13
Update compile time of bundle
0d76d75
Merge branch 'helpers' of github.com:plomino/Plomino into helpers
b93c553
Values may be None
534bf69
Datetime format is on the context
ffe967a
Set a fieldvalue when displaying a datetime example widget
e39fba8
Trim whitespace around elementIds when selecting text
2252adf
Replace a confusing list comprehension
6eb3010
@ivanteoh
Get the ajax datatime value from request and display on the form
a0f9a9e
Add tooltips for the plomino buttons
9a9dfa0
Add a Page break button to TinyMCE and use a page break class to diff…
1e4077e 
…erentiate from a HR
@ivanteoh
Fix the datime default values.
42a2b47
@ivanteoh
Change the log to debug instead of info
1de98c1
When inserting content into TinyMCE, ensure cursor moves to a new line
ce13c24
Return outer_html in handleLabels
beed132
Handle empty forms properly in handleLabels
eb51ed5
Remove debug line that was causing encoding errors
379642d
Add advanced form fields to an advanced fieldset
20edc58
Hide advanced fields on database and field
c084ea0
Add a BR after inserting a HR so that cursor moves to the next line
96cf586
@ivanteoh
Fix #765 datetime does not show right date time format
af59437
@ivanteoh
Fix flake8 warnings.
4014a6a
@ivanteoh
Fix some typo
2da6625
@ivanteoh
Add the missing logger statement.
9c58c28
@ivanteoh
Fix more flake8 warning in datetime
73adfbf
@ivanteoh
Change the rich text editor to 100% width for now
4f731d0
@ivanteoh
Fix the SCRIPT_ID_DELIMITER import error
aba166f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djay @ebrehault @instification @ivanteoh