Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] form layout is error prone and intimidating (dnd fields) #750

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

djay
Copy link
Contributor

@djay djay commented Jul 16, 2016

User problem

Currently layout is done with markup and character styles. Less has the following downsides

  • it's error prone. Hitting enter after a field will continue the style when the user doesn't intend it.
  • you have to know to enter the id name, select it then push the button
  • it makes plomino look harder to use than it is
  • It's harder to get a feel for the layout of the form
  • Styles are only differentiated by colour, which is not accessible

Options

Use tinymce's noneditable mode and inset representative html for fields, actions and subforms. html doesn't have to be perfect but should try to show what the final result will look like.
Labels, displayfields, hidewhens and caches can also use noneditable to take up less space and be less error prone.

Here is an example of WIP for fields
plominovisual

TODO:

  • work out html to display for a datagrid
  • test inserting subforms
  • test inserting action buttons and links
  • use noneditible for labels and hidewhens
  • handle computed fields
  • handle labels
  • make work with IDE
  • show hidden fields
  • show differences between number and text fields
  • click to edit
  • disable table edit controls for datagrid inserted table
  • replace richtext field with an image
  • handle tabs and outlines being offscreen.

@djay djay changed the title [WIP] form layout is not visual enough [WIP] form layout error prone and intimidating Jul 16, 2016
@djay djay changed the title [WIP] form layout error prone and intimidating [WIP] form layout is error prone and intimidating Jul 16, 2016
@djay
Copy link
Contributor Author

djay commented Aug 17, 2016

@ebrehault hi. Is there any progress of the IDE work? One thing thats unintuitive currently is that you have to type the id first and select it before adding a new field. This is obviously something that will change with the IDE, but if its going to take some time I can probably do a quick fix here.

@ebrehault
Copy link
Member

I fixed few bugs in the ide branch before I left to vacations, I guess I need to review it one more time, and then I will release it.

@djay
Copy link
Contributor Author

djay commented Sep 5, 2016

This will also fix - #626

@djay djay changed the title [WIP] form layout is error prone and intimidating [WIP] form layout is error prone and intimidating (dnd fields) Sep 15, 2016
@djay
Copy link
Contributor Author

djay commented Sep 15, 2016

@displacedaussie @ebrehault The current inserting into tinymce is here https://github.com/plomino/Plomino/blob/master/ide/app/editors/tiny-mce.component.ts#L82.

It currently has a bug that it doesn't insert at the cursor. Something like this might fix it - http://blog.squadedit.com/tinymce-and-cursor-position.

Since angular is in typescript we either need to rewrite the code that inserts field etc, or turn it into a function that can be called from TS, or, since we have to do an ajax call to get the widget anyway, we could do it all serverside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants