Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set local context to avoid errors resetting global start method #92

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

DreRnc
Copy link
Contributor

@DreRnc DreRnc commented Dec 25, 2024

Closed the previous PR and reopened a new one because the contrib_dev branch has been deleted in the last couple of days, so I'm merging to main (I hope this is fine, let me know if you prefer the contribution to be merged elsewhere).

This PR is to solve issue #88 to avoid setting the global context multiple times.

@Ninjani
Copy link
Contributor

Ninjani commented Dec 25, 2024

Would you mind running tox -e type to pass the code quality check? Or you can install the pre-commit hook as described here: https://plinder-org.github.io/plinder/contribution/development.html#enabling-pre-commit-hooks

@DreRnc
Copy link
Contributor Author

DreRnc commented Dec 31, 2024

As discussed privately, fixed the trailing whitespace on the docs yaml to pass the quality check

Copy link
Contributor

@Ninjani Ninjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ninjani Ninjani merged commit 5c1b90c into plinder-org:main Dec 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants