Build Puku (more) statically #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
requested changes
Oct 29, 2024
There was a problem hiding this comment.
I don't think this will work on every architecture? I'm pretty sure you can't do this for OSX for example?
I think if we set the osusergo and netgo build tags on the go stdlib, it will come out static on Linux. I'm a bit confused about the setup with the release profile & separate go_toolchain though...
peterebden
approved these changes
Oct 29, 2024
|
I guess you might want to bump the VERSION so we get a new release with the statically built version |
|
🙇 this works for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
Not setting
static = Trueas that won't work well for cross compilation.