Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cgo commands a little #285

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Simplify cgo commands a little #285

merged 1 commit into from
Aug 15, 2024

Conversation

peterebden
Copy link
Contributor

  • we only need the mkdir command if we have a subdir
  • was going to swap arguments to find since it moans sometimes but
  • go tool cgo now supports -trimpath (it probably has for some time) so we can lose the find/xargs

@peterebden peterebden merged commit 3c24da3 into please-build:master Aug 15, 2024
5 checks passed
@peterebden peterebden deleted the cgo-fixen branch August 15, 2024 17:07
@peterebden peterebden mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisnovakovic chrisnovakovic chrisnovakovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterebden @chrisnovakovic