Don't add go_binary to install filegroup for go_repo #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatskaari
force-pushed
the
go-repo-install-binary
branch
from
f395393 to
445ebba
Compare
Tatskaari
force-pushed
the
go-repo-install-binary
branch
from
445ebba to
322b230
Compare
samwestmoreland
approved these changes
Nov 22, 2023
tools/please_go/generate/generate.go
Outdated
| @@ -483,8 +498,21 @@ func trimPath(target, base string) string { | |||
|
|
|||
| // libTargetForPleasePackage returns the build label for the go_library() target that would be generated for a package | |||
There was a problem hiding this comment.
Comment needs updating as well
| return "", err | ||
| } | ||
|
|
||
| libs := append(file.Rules("go_library"), file.Rules("cgo_library")...) |
There was a problem hiding this comment.
So what does it mean here if len(libs) is greater than 1? (and should we be handling it?)
There was a problem hiding this comment.
It can't be unless there's a bug in the rest of the code. We just generated this build file. Maybe I can add a check to assert that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.