Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mkv as an allowed video type, fixes #94 #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkaberg
Copy link

@jkaberg jkaberg commented Apr 3, 2024

No description provided.

@jkaberg
Copy link
Author

jkaberg commented Apr 3, 2024

this fixes #94

also please deploy an new container version while at it 😄

@pldubouilh
Copy link
Owner

Hi, thanks for the PR, and sorry for the slow reply !
I prefer to wait a bit before merging this - support is not super widespread yet, and depending on the codec it can end up in a black screen with no video starting :( I actually implemented forced-download for MKVs after someone reported this very behaviour.
Let's keep an eye on support, and merge this when support lands more broadly 👍

@TakeoIschiFan
Copy link

How about adding a "enable experimental video player features" cli flag, off by default, that enables playback for mkv?

Would not impact most users as it is disabled by default, but the feature is still there for those that want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants