Fix ducks and building rotation #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfarms
reviewed
May 24, 2024
| @@ -75,7 +75,8 @@ export const Buildings = memo( | |||
| const coords = getCoords(b.location.tile); | |||
| const height = getTileHeightFromCoords(coords); | |||
| const selected = selectedElementID === b.id ? 'outline' : 'none'; | |||
| const rotation = b.facingDirection == FacingDirectionKind.RIGHT ? -30 : 30; | |||
| console.log(b); | |||
chrisfarms
reviewed
May 24, 2024
Comment on lines
+1
to
+13
| { | ||
| "useBuildCacheServer": false, | ||
| "cacheServerHost": "", | ||
| "cacheServerPort": 8126, | ||
| "threadedArchiving": true, | ||
| "logCacheMiss": false, | ||
| "slimWriteResults": true, | ||
| "maximumCacheSize": 20, | ||
| "useDetailedBuildLog": false, | ||
| "useV2Hasher": true, | ||
| "fileIDHashSeed": 0, | ||
| "prefabPackedHeaderSize": 2 | ||
| } |
There was a problem hiding this comment.
did you mean to commit this? ... seems unrelated
There was a problem hiding this comment.
I did not mean to commit this... I also don't know what it is 🤔. It may be a left over from playing with the rendering. I'll remove it.
There was a problem hiding this comment.
Ooookay... turns out it's auto-generated and will appear after a build forever, so I guess we need it. It's also been added in the Graphics update PR I made.
chrisfarms
approved these changes
May 24, 2024
ldunnplaymint
approved these changes
May 24, 2024
|
Id gitignore it, easier to remove from the list later than to add it and make sure everyone's local copies get the message! |
ldunnplaymint
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rotates the duck roofs on both the factory buildings and the duck counter buildings so that the face the same direction as the building itself.
It also adjusts how dynamically placed buildings are rotated so that they show off both of their detailed sides