Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial-room-7: ZoneKind #1406

Merged
merged 3 commits into from
May 24, 2024
Merged

tutorial-room-7: ZoneKind #1406

merged 3 commits into from
May 24, 2024

Conversation

Steedie
Copy link
Contributor

@Steedie Steedie commented May 13, 2024

What

Adds tutorial-room-7 to showcase ZoneKind.

Includes examples for:

  • ZONE_USE
  • onCombatStart
  • onUnitArrive

screenshot

Resolves

Copy link
Contributor

@hypnoshock hypnoshock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! The example worked for me. The only comment I have is maybe we need to tell them how to ds destroy tutorial-1 if this tutorial is meant to be applied over it

});
```

I'm using similar helper function as we used to create the dico room ([tutorial-room-4](https://github.com/playmint/ds/blob/main/contracts/src/maps/tutorial-room-4/README.md)), but with some slight modifications to create a walkable path, represented by green tiles, and an unwalkable path, represented by red tiles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on 'disco'


<img src="../tutorial-room-1/readme-images/step3.png" width=200>

Now that we're on `tutorial-room-7`, we are going to draw this over the `tutorial-room-1` area.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should mention about ds destroy here. I'm not sure if we have mentioned it in any of the tutorials but I think it would be good to remind them of it here.

@chrisfarms
Copy link
Contributor

might be cool to implement the javascript bits that tell pathfinding that the tiles cannot be walked on... the Gates in labyrinth do this I think: https://github.com/playmint/ds/blob/main/contracts/src/maps/labyrinth/kinds/buildings/Gates/CoreGate.js#L21-L28

@hypnoshock
Copy link
Contributor

might be cool to implement the javascript bits that tell pathfinding that the tiles cannot be walked on... the Gates in labyrinth do this I think: https://github.com/playmint/ds/blob/main/contracts/src/maps/labyrinth/kinds/buildings/Gates/CoreGate.js#L21-L28

Good idea! I totally forgot we could do this and I was the one who implemented that!

@Steedie
Copy link
Contributor Author

Steedie commented May 13, 2024

might be cool to implement the javascript bits that tell pathfinding that the tiles cannot be walked on... the Gates in labyrinth do this I think: https://github.com/playmint/ds/blob/main/contracts/src/maps/labyrinth/kinds/buildings/Gates/CoreGate.js#L21-L28

Good idea! I totally forgot we could do this and I was the one who implemented that!

Cheers for the feedbacks. All implemented in latest commit: 2fde8f6

@Steedie Steedie linked an issue May 16, 2024 that may be closed by this pull request
@ldunnplaymint ldunnplaymint merged commit 7b34493 into main May 24, 2024
3 checks passed
@ldunnplaymint ldunnplaymint deleted the tutorial-room-7 branch May 24, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Example for ZoneKind with documentation
4 participants