disable construct intent for buggy zones #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's a contract bug preventing the CONSTRUCT_BUILDING_MOBILE_UNIT action for working as intended when the zone id is 40 or more. as a temporary measure we are disabling the build intent for the affected zones so that it reduces the potential confusion of either the resulting "out of bounds" error or the silent failing due to these errors only being debug visisble.
5p0rt5BEArD
reviewed
May 11, 2024
| // fails for zone ids above 40. As a temporary measure to limit confusion we | ||
| // will disable the construct button on these zones while we consider options | ||
| // see: https://github.com/playmint/ds/issues/1402 | ||
| const isBuggyZone = (id: number) => id >= 40; |
There was a problem hiding this comment.
was erring on the safe side of the off-by one ness
There was a problem hiding this comment.
>= 41 is correct
I've confirmed the following two statements locally
- The bug is present on zone 41 but not on zone 40
- The button is not displayed for zone 41 but is displayed for zone 40 with
const isBuggyZone = (id: number) => id >= 41;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's a contract bug preventing the CONSTRUCT_BUILDING_MOBILE_UNIT action for working as intended when the zone id is 40 or more.
as a temporary measure we are disabling the build intent for the affected zones so that it reduces the potential confusion of either the resulting "out of bounds" error or the silent failing due to these errors only being debug visisble.