Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones list paint job part one #1395

Merged
merged 13 commits into from
May 10, 2024
Merged

Zones list paint job part one #1395

merged 13 commits into from
May 10, 2024

Conversation

chrisfarms
Copy link
Contributor

@chrisfarms chrisfarms commented May 9, 2024

what

bringing the zone list page inline with design we want ... not implemented any of the filter controls, but this is the basics and should be working...

Screenshot 2024-05-10 at 12 39 56

why

divergance from mock ups

  • using very simple toggle buttons for "ALL | ACTIVE | YOURS" instead of the complex filter stuff for now, since we don't have enough data for interesting complex filters
  • there is no "sort" options ... things are always sorted by "activity" ... where "activity" is either the number of active units or the time of the last active unit
  • filtering by "ACTIVE" means "show me only zones with more than 1 tile that someone has entered at some point before, then sort them by "activity" as above

@ldunnplaymint
Copy link
Contributor

If I mint a zone, I don't see it immediately as no one is active. I think the filter should switch to "Yours" if you mint a zone.

@chrisfarms
Copy link
Contributor Author

If I mint a zone, I don't see it immediately as no one is active. I think the filter should switch to "Yours" if you mint a zone.

👍 ... pushed change that does this

I have also made it so that "ACTIVE" always shows you your own zones even if they are not technically active, as this seems less surprizing

@ldunnplaymint
Copy link
Contributor

The mint success text is wrong, always was but now way more obvious
Screenshot 2024-05-10 at 13 25 25

@chrisfarms chrisfarms force-pushed the zone-list-paint-job branch from 373b57f to 1816446 Compare May 10, 2024 12:25
@chrisfarms
Copy link
Contributor Author

The mint success text is wrong...

what do you want it to say?

@ldunnplaymint
Copy link
Contributor

ldunnplaymint commented May 10, 2024

The mint success text is wrong...

what do you want it to say?

"Mint successful! Please find your Zone in the list below!"

@ldunnplaymint
Copy link
Contributor

The bottom playmint button does nothing

@chrisfarms
Copy link
Contributor Author

The bottom playmint button does nothing

it's not a button, just a logo 🤷

@ldunnplaymint
Copy link
Contributor

The bottom playmint button does nothing

it's not a button, just a logo 🤷

It looks like a button 🤔

@chrisfarms chrisfarms merged commit 93483f7 into main May 10, 2024
3 checks passed
@chrisfarms chrisfarms deleted the zone-list-paint-job branch May 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no sorting for spotlighted zones implement frontpage design
2 participants