Recognize hook on record beep #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recordButton press means, the hook is back on it (make sure to have your raising/falling edge right). If the hook is back on, the wait function is interrupted and returns false. If wait was able to run through, it returns true.
before starting the record, check if while is running through without interrupts (returning true). If so, start recording. If wait is interrupted and returns false, immediately stop the beep and get into ready mode
|
Also fixed in PR #47 back in May. No point, really: nothing's been pulled since last November... it's not even as if the account is inactive, either. |
if the hook is taken of and immediately returned, the greeting will no more be played.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After building the audio-guestbook and using it on a wedding for the first time, I came across an issue: If you put the hook back, while the beep before the recording is played, the hook press is not recognized. The problem is: while in the
wait()-function, button presses are recognized, but not communicated to outside ofwait().I found some issues for this problem, but was not convinced of the solutions (max recording time 120seconds), so I made this one.
I made
wait()returnbooleaninstead ofvoid. If therecordButtonis pressed, the hook is back on it (raising/falling edge still need to be checked for your specific telephone). If the hook is back on, thewait()-function is interrupted and returnsfalse. Ifwait()was able to run through, it returnstrue.Before starting the record, it's checked if
wait()is running through without interrupts (returningtrue). If so, start recording. Ifwait()is interrupted and returnsfalse, immediately stop the beep and get into modeReady.