correct errata36() for gpio 32 and 33 (esp-rs#1053)

* correct errata36() for gpio 32 and 33 * update changelog
playfulFence · Dec 28, 2023 · 2e2d67f · 2e2d67f
1 parent 07b2b0d
commit 2e2d67f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- ESP32: correct gpio 32/33 in errata36() (#1053)
+
 ### Removed
 
 ## [0.14.1] - 2023-12-13

diff --git a/esp-hal-common/src/soc/esp32/gpio.rs b/esp-hal-common/src/soc/esp32/gpio.rs
@@ -683,18 +683,18 @@ pub(crate) fn errata36(pin_num: u8, pull_up: bool, pull_down: bool) {
         32 => {
             rtcio.xtal_32k_pad().modify(|r, w| unsafe {
                 w.bits(r.bits())
-                    .x32n_rue()
+                    .x32p_rue()
                     .bit(pull_up)
-                    .x32n_rde()
+                    .x32p_rde()
                     .bit(pull_down)
             });
         }
         33 => {
             rtcio.xtal_32k_pad().modify(|r, w| unsafe {
                 w.bits(r.bits())
-                    .x32p_rue()
+                    .x32n_rue()
                     .bit(pull_up)
-                    .x32p_rde()
+                    .x32n_rde()
                     .bit(pull_down)
             });
         }