feat(spine): Adds a Spine Package #9
Conversation
- fixed json and test - fixed texture packer still creating individual images - ensure output is removed if the cache key changes
- fix compressed pngs not working
- remove spineAtlasMipmap from mipmap-compress - fix png compression - add spine package
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your PR title doesn't match the required format. The title should be in the conventional commit (https://www.conventionalcommits.org/en/v1.0.0-beta.4/) format. e.g.
chore(plugin-name): add pr title workflow
Zyie
changed the title
| @@ -100,15 +133,19 @@ function collectAssets( | |||
| { | |||
| bundleAssets.push({ | |||
| alias: getShortNames(stripTags(path.relative(entryPath, `${asset.path}-${pageIndex}`)), options), | |||
| src: pages.map((finalAsset) => path.relative(outputPath, finalAsset.path)) | |||
| src: pages | |||
There was a problem hiding this comment.
it doesn't seem like we are adding data anymore?
we used to add all the tags to the manifest
| @@ -20,7 +20,7 @@ export async function compressSharp( | |||
| compressed.push({ | |||
| format: '.png', | |||
| resolution: image.resolution, | |||
| sharpImage: sharpImage.clone(), | |||
| sharpImage: sharpImage.clone().png({ ...options.png as PngOptions, force: true }), | |||
There was a problem hiding this comment.
this seems weird, why is it being compressed multiple times?
| const defaultOptions = { | ||
| ..._options, | ||
| tags: { | ||
| tps: 'tps', |
There was a problem hiding this comment.
this doesn't seem right, why would spine need a tps tag?
also you are missing the nc tag definition
| import type { CompressOptions } from '@play-co/assetpack-plugin-mipmap-compress'; | ||
| import { AtlasView } from './AtlasView'; | ||
|
|
||
| export type SpineAtlasCompressOptions = PluginOptions<'tps' | 'nc'> & CompressOptions; |
|
|
||
| export type SpineAtlasCompressOptions = PluginOptions<'tps' | 'nc'> & CompressOptions; | ||
|
|
||
| export function spineAtlasCompress(_options?: SpineAtlasCompressOptions): AssetPipe<SpineAtlasCompressOptions> |
There was a problem hiding this comment.
can we make sure variables are not _
| expect(rawAtlasWebpHalf.includes('[email protected]')).toBeTruthy(); | ||
| }); | ||
|
|
||
| // it('should correctly create files when Mipmap and CacheBuster are used', async () => |
There was a problem hiding this comment.
any reason why these have been left?
| @@ -1,12 +1,13 @@ | |||
| import type { Asset, AssetPipe, PluginOptions } from '@play-co/assetpack-core'; | |||
| import { checkExt, createNewAssetAt, swapExt } from '@play-co/assetpack-core'; | |||
| import fs from 'fs-extra'; | |||
| import type { CompressOptions } from '@play-co/assetpack-plugin-mipmap-compress'; | |||
There was a problem hiding this comment.
you've added a dependency here, but not added it to the package.json
|
|
||
| export function texturePackerCompress(_options?: TexturePackerCompressOptions): AssetPipe<TexturePackerCompressOptions> | ||
| { | ||
| const defaultOptions = { | ||
| ..._options, | ||
| tags: { | ||
| tps: 'tps', |
There was a problem hiding this comment.
no definition for the nc tag
spineAtlasCompressspineAtlasMipmapskipChildrento Asset which allows for skipping of assets in the manifest