Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Average Scroll Depth Metric: extracted tracker changes #4826

Merged
merged 17 commits into from
Nov 21, 2024
Merged

Average Scroll Depth Metric: extracted tracker changes #4826

merged 17 commits into from
Nov 21, 2024
+402 −91

Commits on Nov 14, 2024

  1. (cherry-pick) implement scroll depth tracking under pageleave variant

    @RobertJoonas
    RobertJoonas committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ceac028 View commit details
    Browse the repository at this point in the history

  2. drop unnecessary vars

    @RobertJoonas
    RobertJoonas committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5d06489 View commit details
    Browse the repository at this point in the history

  3. remove unused require

    @RobertJoonas
    RobertJoonas committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    371bbd0 View commit details
    Browse the repository at this point in the history

  4. add scroll depth tests

    @RobertJoonas
    RobertJoonas committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8ae1a81 View commit details
    Browse the repository at this point in the history

  5. improve error messages in test util

    @RobertJoonas
    RobertJoonas committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    79f4b68 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. reevaluate currentDocumentHeight on page load

    @RobertJoonas
    RobertJoonas committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a5b22fa View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. account for dynamically loaded content when initializing documnent he… 

    …ight
    @RobertJoonas
    RobertJoonas committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8eec711 View commit details
    Browse the repository at this point in the history

  2. remove all semicolons from tracker specs

    @RobertJoonas
    RobertJoonas committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    80c40b7 View commit details
    Browse the repository at this point in the history

  3. allow window and document globals in tracker eslint

    @RobertJoonas
    RobertJoonas committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    0f0d600 View commit details
    Browse the repository at this point in the history

  4. tweak global tracker dir eslint rules

    @RobertJoonas
    RobertJoonas committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7892a17 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into scroll-depth-tracking

    @RobertJoonas
    RobertJoonas authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    514dd9b View commit details
    Browse the repository at this point in the history

  6. update comment

    @RobertJoonas
    RobertJoonas committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9a1c612 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Merge branch 'master' into scroll-depth-tracking

    @RobertJoonas
    RobertJoonas authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d18c7e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. reevaluate document height on scroll

    @RobertJoonas
    RobertJoonas committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6bc3a29 View commit details
    Browse the repository at this point in the history

  2. add test

    @RobertJoonas
    RobertJoonas committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a709fc5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into scroll-depth-tracking

    @RobertJoonas
    RobertJoonas authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6868049 View commit details
    Browse the repository at this point in the history

  4. remove unneccessary timeout

    @RobertJoonas
    RobertJoonas committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a90bdfe View commit details
    Browse the repository at this point in the history