Update make commands

platine-php · Sep 17, 2023 · 67d5d0b · 67d5d0b
1 parent 471dff1
commit 67d5d0b
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 6 deletions.
diff --git a/src/Console/Command/MakeEntityCommand.php b/src/Console/Command/MakeEntityCommand.php
@@ -134,12 +134,14 @@ public function getClassTemplate(): string
         /**
         * @class %classname%
         * @package %namespace%
+        * @extends Entity<%classname%>
         */
         class %classname% extends Entity
         {
             
             /**
-            * {@inheritdoc}
+            * @param EntityMapperInterface<%classname%> \$mapper
+            * @return void
             */
             public static function mapEntity(EntityMapperInterface \$mapper): void
             {

diff --git a/src/Console/Command/MakeFormParamCommand.php b/src/Console/Command/MakeFormParamCommand.php
@@ -161,6 +161,7 @@ public function getClassTemplate(): string
         /**
         * @class %classname%
         * @package %namespace%
+        * %template_entity%
         */
         class %classname% extends BaseParam
         {
@@ -278,10 +279,12 @@ public function $getterName(): string
     protected function getFromEntityBody(string $content): string
     {
         $result = '';
+        $templateEntity = '@template TEntity as Entity';
         if ($this->createInstanceFormEntity && !empty($this->fromEntityMaps)) {
             $result = <<<EOF
             /**
-                * {@inheritdoc}
+                * @param TEntity \$entity
+                * @return \$this
                 */
                public function fromEntity(Entity \$entity): self
                {
@@ -301,8 +304,10 @@ public function fromEntity(Entity \$entity): self
             
             EOF;
         }
-
-        return str_replace('%from_entity%', $result, $content);
+
+        $template = (string) str_replace('%from_entity%', $result, $content);
+
+        return str_replace('%template_entity%', $templateEntity, $template);
     }
 
     /**

diff --git a/src/Console/Command/MakeRepositoryCommand.php b/src/Console/Command/MakeRepositoryCommand.php
@@ -121,13 +121,14 @@ public function getClassTemplate(): string
         /**
         * @class %classname%
         * @package %namespace%
+        * @extends Repository<%entity_base_class%>
         */
         class %classname% extends Repository
         {
             
             /**
             * Create new instance
-            * @param EntityManager \$manager
+            * @param EntityManager<%entity_base_class%> \$manager
             */
            public function __construct(EntityManager \$manager)
            {
@@ -164,7 +165,9 @@ protected function getUsesContent(): string
     protected function getEntityBody(string $content): string
     {
         $entityName = basename($this->entityClass) . '::class';
+        $entityBaseName = $this->getClassBaseName($this->entityClass);
 
-        return str_replace('%entity_class%', $entityName, $content);
+        $template = str_replace('%entity_base_class%', $entityBaseName, $content);
+        return str_replace('%entity_class%', $entityName, $template);
     }
 }
diff --git a/src/Console/MakeCommand.php b/src/Console/MakeCommand.php
@@ -176,6 +176,22 @@ public function interact(Reader $reader, Writer $writer): void
 
         $this->className = $name;
     }
+
+    /**
+     * Return the base class name
+     * @param string|object $fullClassName
+     * @return string
+     */
+    public function getClassBaseName($fullClassName): string
+    {
+        if (is_object($fullClassName)) {
+            $fullClassName = get_class($fullClassName);
+        }
+
+        $temp = explode('\\', $fullClassName);
+
+        return end($temp);
+    }
 
     /**
      * Return the the class template

diff --git a/tests/Console/Command/MakeActionCommandTest.php b/tests/Console/Command/MakeActionCommandTest.php
@@ -11,6 +11,7 @@
 use Platine\Framework\App\Application;
 use Platine\Framework\Console\Command\MakeActionCommand;
 use Platine\Test\Framework\Console\BaseCommandTestCase;
+use stdClass;
 
 /*
  * @group core
@@ -47,6 +48,10 @@ public function testExecuteDefault(): void
         $o->bind($consoleApp);
         $o->parse(['platine', $actionName]);
         $this->assertEquals('make:action', $o->getName());
+
+        // Only to coverage tests
+        $this->assertEquals('MakeActionCommandTest', $o->getClassBaseName($this));
+        $this->assertEquals(stdClass::class, $o->getClassBaseName(stdClass::class));
 
         $o->interact($reader, $writer);
         $o->execute();