-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(board): Add Heltec Wireless Paper and Wireless Tracker #1447
base: develop
Are you sure you want to change the base?
Conversation
@ivankravets Please check if there is any issue. These two boards have been out for a long time and have been stable running on the Espressif Arduino. |
Hi @RichardHeltec, these boards were added in Arduino core v3.x which is not supported at the moment. Besides, your manifest files needs some adjustments, please review my comments above. |
|
@valeros Sorry, my mistake. I have made the modification. Please review it again. |
@RichardHeltec I believe the board-specific macro should be uppercase, e.g. |
Hi, Valerii. If capitalization is necessary, I will make the necessary modifications. At the same time, I found that the boards that are already running on the platform, such as "wifi lora 32 v3", "wifi kit v3", are still lowercase, should I change them? |
@RichardHeltec
It seems like an old typo from a PR. Anyway, it would be great, but please submit your fixes in a separate pull request. |
@valeros Hi, Valerii. I have modified the corresponding files of Wireless Tracker and Wireless Paper to uppercase, please review. |
LGTM, the PR will be merged once support for Arduino core v3.0 is added. |
Hi, Valerii. This morning, I was feeling dazed. I thought I saw my commit being merged, so I updated my branch again. It turns out I was wrong now. I'm not sure if it will affect your review. |
Can this PR be merged please? |
Add Heltec Wireless Paper and Wireless Tracker.
Wireless Tracker
Wireless Paper