Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(board): Add Heltec Wireless Paper and Wireless Tracker #1447

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Richard3366
Copy link

Add Heltec Wireless Paper and Wireless Tracker.
Wireless Tracker
Wireless Paper

@Richard3366
Copy link
Author

@ivankravets Please check if there is any issue. These two boards have been out for a long time and have been stable running on the Espressif Arduino.

boards/heltec_wireless_paper.json Outdated Show resolved Hide resolved
boards/heltec_wireless_paper.json Outdated Show resolved Hide resolved
boards/heltec_wireless_paper.json Outdated Show resolved Hide resolved
@valeros
Copy link
Member

valeros commented Aug 22, 2024

Hi @RichardHeltec, these boards were added in Arduino core v3.x which is not supported at the moment. Besides, your manifest files needs some adjustments, please review my comments above.

@Richard3366
Copy link
Author

Hi @RichardHeltec, these boards were added in Arduino core v3.x which is not supported at the moment. Besides, your manifest files needs some adjustments, please review my comments above.
Sorry, my mistake. I have made the modification. Please review it again.

@Richard3366
Copy link
Author

@valeros Sorry, my mistake. I have made the modification. Please review it again.

@valeros
Copy link
Member

valeros commented Aug 23, 2024

@RichardHeltec I believe the board-specific macro should be uppercase, e.g. -DARDUINO_HELTEC_WIRELESS_PAPER

@Richard3366
Copy link
Author

@RichardHeltec I believe the board-specific macro should be uppercase, e.g. -DARDUINO_HELTEC_WIRELESS_PAPER

Hi, Valerii. If capitalization is necessary, I will make the necessary modifications. At the same time, I found that the boards that are already running on the platform, such as "wifi lora 32 v3", "wifi kit v3", are still lowercase, should I change them?

@valeros
Copy link
Member

valeros commented Aug 24, 2024

@RichardHeltec

At the same time, I found that the boards that are already running on the platform, such as "wifi lora 32 v3", "wifi kit v3", are still lowercase, should I change them?

It seems like an old typo from a PR. Anyway, it would be great, but please submit your fixes in a separate pull request.

@Richard3366
Copy link
Author

@valeros Hi, Valerii. I have modified the corresponding files of Wireless Tracker and Wireless Paper to uppercase, please review.

@valeros
Copy link
Member

valeros commented Aug 26, 2024

LGTM, the PR will be merged once support for Arduino core v3.0 is added.

@Richard3366
Copy link
Author

Hi, Valerii. This morning, I was feeling dazed. I thought I saw my commit being merged, so I updated my branch again. It turns out I was wrong now. I'm not sure if it will affect your review.
These boards are already integrated into Espressif's framework.

@galets
Copy link

galets commented Nov 19, 2024

Can this PR be merged please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants