Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parameters and make performance updates #128

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

jalving
Copy link
Member

@jalving jalving commented Nov 2, 2024

This PR makes the following key changes:

  • Fixes an issue with slow set_to_node_objectives. When node objectives are linear or quadratic, they now hit the add_to_expression! method which is more efficient. Nonlinear objectives are still slow, however.
  • Adds support for variables constrained on creation.
  • Adds support for MOI parameters
  • Adds methods for checking if an objective function is separable and extract separable terms for a given optigraph
  • Other minor refactoring and comments

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 53.52697% with 112 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (8c2e276) to head (21614fc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/utils.jl 20.00% 96 Missing ⚠️
src/node_variables.jl 87.27% 7 Missing ⚠️
src/optiedge.jl 20.00% 4 Missing ⚠️
src/optigraph.jl 90.00% 3 Missing ⚠️
src/backends/moi_backend.jl 91.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   83.81%   80.98%   -2.84%     
==========================================
  Files          16       17       +1     
  Lines        2571     2756     +185     
==========================================
+ Hits         2155     2232      +77     
- Misses        416      524     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jalving jalving changed the title Jalving parameters and performance updates support parameters and make performance updates Nov 2, 2024
@jalving
Copy link
Member Author

jalving commented Nov 2, 2024

FYI @dlcole3

@jalving jalving merged commit 0a22e91 into plasmo-dev:main Nov 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants