Redesign block-based interface to graph-based interface #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets away from the block interface and implements a pure graph data structure in MathOptInterface. We adopt the name
GraphOptInterface.OptiGraph
as the primary data structure. It works in a similar way to Plasmo.jl, but it instead defines MOI models on nodes and edges.Also note that we initially tried designing the data-structure such that nodes only contained variables (and bounds); whereas edges contained MOI models with constraints. I found this to make the interface somewhat inconsistent as constraints on nodes required the use of self-edges so users would handle them differently. The self-edges also made implementation quite messy for reasons related to extending MOI.