Upgrade Node version #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade Node to v4.8.4 which contains some security fixes (ref: https://nodejs.org/en/blog/vulnerability/july-2017-security-releases/).
pdziok
reviewed
Jul 13, 2017
| @@ -7,12 +7,12 @@ | |||
| "start": "node app.js" | |||
| }, | |||
| "engines": { | |||
| "node": "0.12.x" | |||
| "node": "4.8.4" | |||
There was a problem hiding this comment.
You might want to add caret (^) in front of the version so the people using higher versions in major 4 could use it as well.
There was a problem hiding this comment.
What @pdziok said.
Also, funky indentation yo.
|
👋 @mzb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Node to v4.8.4 which contains some security fixes (ref:
https://nodejs.org/en/blog/vulnerability/july-2017-security-releases/).
I also upgraded
node-sass-middlewarebc of problems with buildingnode-sass.