Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Publish react-native-plaid-linkkit to npm (w/ ts types) #328

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tonyxiao
Copy link

To make it easier for developers to use.

I see that this repo is marked as deprecated, however I don't see anywhere else where I can actually submit this PR. So here goes.

@afh
Copy link
Contributor

afh commented Jun 10, 2019

Hi @tonyxiao,

thanks for your contribution. We're in the midst of restructuring our repositories and the Plaid Link for iOS SDK (a.k.a. LinkKit) now lives under plaid/plaid-ios.
We may split out its react-native component to another repository.

Until the transition is complete mind addressing the TODOs in the changes you propose?

@pbernasconi
Copy link
Contributor

hey @tonyxiao – this is great stuff, thanks for opening up a PR!

I'm currently working on an official Plaid-supported react-native npm library that we plan to release in the near future.

Would you be open to collab on it together? For now I'm going to leave this PR open and un-reviewed while we build out the official library, but would love to share the first version with you soon for feedback!

@tonyxiao
Copy link
Author

@afh yea, react-native as a separate repo makes sense as we'll likely want a single interface for both platforms.

And @pbernasconi - sounds great, definitely happy to collaborate. FYI there's one more commit that we needed for our integration that I didn't add to this PR so far because it changes the API. Long story short publicToken and institution should be change-able at open time. The reason we can't just call create multiple times is because it would cause multiple event emitters to be registered.

alkafinance@6621fe4

Also, I'm about to add something that would prevent open from being called multiple times while a link session is already open .

@tonyxiao
Copy link
Author

@afh out of curiosity, why split into multiple repos? It actually seemed really nice that everything was all in one repo and accessible.

@tonyxiao
Copy link
Author

Totally separate question (there's no ability to create a issue either here or in https://github.com/plaid/plaid-ios/ :( ).

According to docs (https://plaid.com/docs/#onevent-callback), we should get a callback for SUBMIT_CREDENTIALS event. However, when using latest version of plaid sdk (1.1.19), we're not seeing the SUBMIT_CREDENTIALS event. (see logs here https://gist.github.com/tonyxiao/c582958004edea405dd005dd9f142bc6)

Let me know where's the best place to submit issues like this.

@afh
Copy link
Contributor

afh commented Jun 10, 2019

Hi @tonyxiao until we've completed the transition please open a support ticket through the Plaid dashboard to file the issue about the missing SUBMIT_CREDENTIALS event.

To answer your question about the split into multiple repositories: A monorepo makes things harder for tools like CocoaPods or npm, which make certain assumptions about the project structure (e.g. Podspec needs to reside at the repo top-directory).

@tonyxiao
Copy link
Author

Great, thanks for the explanation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants