-
Notifications
You must be signed in to change notification settings - Fork 132
Publish react-native-plaid-linkkit to npm (w/ ts types) #328
base: master
Are you sure you want to change the base?
Conversation
Hi @tonyxiao, thanks for your contribution. We're in the midst of restructuring our repositories and the Plaid Link for iOS SDK (a.k.a. LinkKit) now lives under plaid/plaid-ios. Until the transition is complete mind addressing the |
hey @tonyxiao – this is great stuff, thanks for opening up a PR! I'm currently working on an official Plaid-supported react-native npm library that we plan to release in the near future. Would you be open to collab on it together? For now I'm going to leave this PR open and un-reviewed while we build out the official library, but would love to share the first version with you soon for feedback! |
@afh yea, react-native as a separate repo makes sense as we'll likely want a single interface for both platforms. And @pbernasconi - sounds great, definitely happy to collaborate. FYI there's one more commit that we needed for our integration that I didn't add to this PR so far because it changes the API. Long story short Also, I'm about to add something that would prevent |
@afh out of curiosity, why split into multiple repos? It actually seemed really nice that everything was all in one repo and accessible. |
Totally separate question (there's no ability to create a issue either here or in https://github.com/plaid/plaid-ios/ :( ). According to docs (https://plaid.com/docs/#onevent-callback), we should get a callback for Let me know where's the best place to submit issues like this. |
Hi @tonyxiao until we've completed the transition please open a support ticket through the Plaid dashboard to file the issue about the missing To answer your question about the split into multiple repositories: A monorepo makes things harder for tools like CocoaPods or npm, which make certain assumptions about the project structure (e.g. Podspec needs to reside at the repo top-directory). |
Great, thanks for the explanation. |
To make it easier for developers to use.
I see that this repo is marked as deprecated, however I don't see anywhere else where I can actually submit this PR. So here goes.