Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always set psgi.input to be buffered even when Content-Type is not set #656

Closed
wants to merge 2 commits into from

Conversation

miyagawa
Copy link
Member

@miyagawa miyagawa commented Nov 27, 2020

fixes #655

work around a potential interop issue with HTTP::Entity::Parser not resetting psgi.input when Content-Type header is not set.

Set a dummy application/octet-stream default content type when it's not set so that HTTP::Entity::Parser will parse it as a blob. Also stop short-circuiting the parser logic inside Plack::Request as well.

@haarg @kazeburo

@miyagawa
Copy link
Member Author

alternative kazeburo/HTTP-Entity-Parser#14

@kazeburo
Copy link
Contributor

Released HTTP::Entity::Parser 0.25.
https://metacpan.org/release/KAZEBURO/HTTP-Entity-Parser-0.25

@miyagawa
Copy link
Member Author

closing in favor of #657

@miyagawa miyagawa closed this Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't locate object method "seek" ... if Content-Type header is omitted
2 participants