Draft: v0.2.0 #11
Merged
Draft: v0.2.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use 'impl Future' returns for trait contracts: prevents hidden requirments - refactor tower design around immutable services: easier to reason and use, more natural to use like this, makes it also more clear that user needs to handle state properly, prevents state keeping in service when not required and easier to integrate with other code bases in ecosystem (e.g. hyper)
added 28 commits
November 15, 2023 22:10
getting stuck on trait bounds regarding ServiceBuilder... hmmm
still very poor UX though...
Next steps: - complete 'tower_async_hyper': - integrate tests in tower-http; - add documentation; - remove unneeded hyper references in tower-async-http (especially in doctests) - reintroduce tower-async-bridge + make todo tests pass - update changelogs - review the http upgrade PR in tower-http + compare with tower-async-http PR (this one) - use git version of tower-async in Rama to see if all is good to use - do not use git versions of deps where not needed (eg hyper-util is now available)
instead of direct git references
now on_eos is called again, woohoo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
giant refactor: immutable services and impl traits
just
Add justfile for easier developer experience (
just qato run them all).