feat(http-types): implement IntoResponse for Either types #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IntoResponse implementations for Either types from rama_core::combinators. This allows Either types to be used as responses in handlers. Added unit tests to verify the implementations work correctly for: - Either<&str, Vec<u8>> - Either3<&str, Vec<u8>, StatusCode>
YHM404
force-pushed
the
zot6/either_into_response
branch
from
e453a86 to
b35ef40
Compare
GlenDC
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #395
Add IntoResponse implementations for Either types from rama_core::combinators. This allows Either types to be used as responses in handlers.
Added unit tests to verify the implementations work correctly for: