-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolchain Upgrade: CMake, Conan, GitHub Actions, and more #138
Open
hrz6976
wants to merge
65
commits into
pkumod:1.2
Choose a base branch
from
hrz6976:for-merge
base: 1.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!possibly breaking, tests are required
…ingindex::randomaccess to kvstore::getstringbyid.
Some of the tests have hard-coded paths to HUGE datasets (10GB compressed), so no luck for them :(
fix(docker): dockerfile regression fix(build): cmake coverage regression fix(ci): tarball is missing ci: use vars, not secrets for public info fix: cp: ../lib/x.so is the same file ci: prepare first ci: build verbosely in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR is protentially breaking!
With a lot of file restructuring, includes renaming and reordering, the codebase is prone to break after merging this PR.
I'm not able to run the entire test suite, please double check the changes and make sure all tests pass before merge.
Changes in this PR
TODOs
Add a CI pipeline to automatically build and test gStore on every PR & commit to the default branch.DISCLAIMER
This PR is a part of the course project in PKU's graph data management course.