Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new pkgdev commit mangle to remove stable keywords #202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anthonyryan1
Copy link

One of the most common maintenance tasks in the tree is a simple version bump. With this mangle, pkgdev commit can automatically remove the stable keyword from ebuilds copied from a prior version.

This should reduce contributor mistakes, and save developers time on both code review and manually editing keywords for their commits.

One of the most common maintenance tasks in the tree is a simple
version bump. With this mangle, `pkgdev commit` can automatically
remove the stable keyword from ebuilds copied from a prior version.

This should reduce contributor mistakes, and save developers time
on both code review and manually editing keywords for their commits.
@anthonyryan1
Copy link
Author

anthonyryan1 commented Nov 25, 2024

Following some discussion in #gentoo-dev-help

--mangle false allows this to be disabled on a per-commit basis, piggybacking the existing option. @thesamesam expressed some opinion that this should have a separate toggle, but I felt like general helpful mangling all kind of fit well under that existing flag.

One problem I realized with this, is that it could destabilize a package unintentionally if the whole package is moved by git mv

For example git mv old-category/package new-category/package or git mv category/oldname category/newname would be caught up in this, and the new name would lose it's stability flags.

@anthonyryan1
Copy link
Author

I've added a second commit to cover the scenario where a package is renamed or moved to another category.

Because git treats all add & delete in the same commit as mv operations, we need to use a different approach to distinguish the two scenarios, we're now only removing stable keywords when the PV changes.

Happy to squash the commits, but I've left them separate until discussion is a bit further along.

Only redo the keywords if the PV changes over the git mv operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant