Update git blame ignore list, add mgórny and marienz to authors #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…around. The point here is to be able to look back through time on the evolution to understand what/why things changed. In particular, it's useful to trace back and get a sense of the age of the code and use that as a gauge for the potential that things changed w/out it being updated, or was working around things from py2.4 era. This is from a manual audit, so I didn't catch everything, and some stuff (minor renames or things the history isn't worth linking) I left out based on a quick scan of commit message and coarse file changes. Signed-off-by: Brian Harring <[email protected]>
This is based on mixture of my knowledge and the invocation below.
Current *approximate* authorship based on git deltas (ignoring testdata since
it's not usually in LOC and tree-sitter-bash since it's a vendored import)
```
ferringb@frith ~/gentoo/pkgcheck $ git ls-files | grep -v testdata/ | grep -v tree-sitter-bash/ | xargs -n1 git blame -ew | cut -d\< -f2 | cut -d\> -f1 | cut -d\@ -f1 | sort -g | uniq -c | sort -gr
17265 radhermit
10391 arthurzam
1410 mgorny
933 ferringb
199 marienz
```
Note things like tweaking a line to use a genexp (py>=2.4) rather than
listcomp (py>=2.3) obscures ownership and doesn't actually override original
ownership.
mgorny is added for obvious reasons- copyright + activity.
Myself and Marienz are in there since pre 2013 I wrote... a lot.. (~66% loc, all functionality),
and Marien wrote a lot of checks + tests prior to dropping off in 2006 (~33% loc even as of 2013).
It's not obvious without looking through annotations and having some historical knowledge,
but fundamental bits and fundamental addons (UseAddon for example) were his and are still *there*
even if minor code tweaks obscure it. Minimally they should be in this list based on the
significance and importance of contribution alone.
Signed-off-by: Brian Harring <[email protected]>
|
I'd normally commit something like this, but doing PR to ensure no issues from others as to the change. |
arthurzam
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as pkgcore/pkgcore#429 ; I manually audited the history for the rev list and for double checking on who had what contributions, and what contributions still live on despite code reshuffling and variable renames obscuring it. Marienz is the one who still has intrinsics underneath the various additions and fingerprints. Not a lot, but core components/contributions. Things like use addon or metadata checks, although again- it's obscured by the years. That's still their copyright however.
Finally, Michaeł Górny should be added for obvious reasons.