UnstableSrcUri: check for unstable SRC_URI #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
==========================================
- Coverage 79.77% 79.76% -0.02%
==========================================
Files 58 58
Lines 8652 8667 +15
Branches 1966 1970 +4
==========================================
+ Hits 6902 6913 +11
- Misses 1648 1650 +2
- Partials 102 104 +2
☔ View full report in Codecov by Sentry. |
mgorny
reviewed
Jul 7, 2023
arthurzam
force-pushed
the
check-unstable-uri
branch
from
7f1444d to
68adf7c
Compare
arthurzam
force-pushed
the
check-unstable-uri
branch
from
68adf7c to
f2a83ca
Compare
mgorny
reviewed
Sep 1, 2023
| DESCRIPTION="Ebuild with unstable SRC_URI" | ||
| HOMEPAGE="https://github.com/pkgcore/pkgcheck" | ||
| SRC_URI=" | ||
| https://patch-diff.githubusercontent.com/raw/pkgcore/pkgcheck/pull/599.patch |
There was a problem hiding this comment.
Will this check catch also the pre-redirect https://github.com/foo/bar/pull/1234.patch form? Perhaps we should do that as well.
There was a problem hiding this comment.
It didn't catch in original version, updated and included in tests.
Resolves: pkgcore#510 Signed-off-by: Arthur Zamarin <[email protected]>
arthurzam
force-pushed
the
check-unstable-uri
branch
from
f2a83ca to
c6f50b4
Compare
gentoo-bot
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've currently collected the patterns from the linked issues. I can add more as requested.
For ::gentoo it results in:
For ::guru it results in:
Resolves: #505
Resolves: #510