BannedEapiCommand: add some extra user/group commands

Add some commands which should never be called in ebuild to the banned list. Signed-off-by: Arthur Zamarin <[email protected]>
pkgcore · Oct 5, 2023 · 348ad0a · 348ad0a
1 parent a19030f
commit 348ad0a
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 0 deletions.
diff --git a/src/pkgcheck/checks/codingstyle.py b/src/pkgcheck/checks/codingstyle.py
@@ -75,6 +75,19 @@ class BadCommandsCheck(Check):
     _source = sources.EbuildParseRepoSource
     known_results = frozenset({DeprecatedEapiCommand, BannedEapiCommand, BannedPhaseCall})
 
+    extra_banned_commands = frozenset(
+        {
+            # commands that modify user/group databases, not portable
+            "gpasswd",
+            "groupadd",
+            "groupdel",
+            "groupmod",
+            "useradd",
+            "userdel",
+            "usermod",
+        }
+    )
+
     def feed(self, pkg):
         for func_node, _ in bash.func_query.captures(pkg.tree.root_node):
             for node, _ in bash.cmd_query.captures(func_node):
@@ -100,6 +113,10 @@ def feed(self, pkg):
                         yield BannedEapiCommand(
                             name, line=call, lineno=lineno + 1, eapi=pkg.eapi, pkg=pkg
                         )
+                elif name in self.extra_banned_commands:
+                    yield BannedEapiCommand(
+                        name, line=call, lineno=lineno + 1, eapi=pkg.eapi, pkg=pkg
+                    )
 
 
 class EendMissingArg(results.LineResult, results.Warning):

diff --git a/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/expected.json b/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/expected.json
@@ -1,3 +1,5 @@
 {"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package": "BannedEapiCommand", "version": "0", "line": "dohtml doc/*", "lineno": 9, "command": "dohtml", "eapi": "7"}
 {"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package": "BannedEapiCommand", "version": "1", "line": "has_version --host-root stub/stub1", "lineno": 9, "command": "has_version --host-root", "eapi": "7"}
 {"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package": "BannedEapiCommand", "version": "1", "line": "best_version --host-root stub/stub1:2", "lineno": 12, "command": "best_version --host-root", "eapi": "7"}
+{"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package": "BannedEapiCommand", "version": "2", "line": "usermod -s /bin/bash uucp", "lineno": 9, "command": "usermod", "eapi": "6"}
+{"__class__": "BannedEapiCommand", "category": "BadCommandsCheck", "package": "BannedEapiCommand", "version": "2", "line": "usermod -s /bin/false uucp", "lineno": 13, "command": "usermod", "eapi": "6"}
diff --git a/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/fix.patch b/testdata/data/repos/standalone/BadCommandsCheck/BannedEapiCommand/fix.patch
@@ -24,3 +24,18 @@ diff -Naur standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-1.ebu
 -	H=$(best_version --host-root stub/stub1:2)
 +	H=$(best_version -b stub/stub1:2)
  }
+diff -Naur standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-2.ebuild fixed/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-2.ebuild
+--- standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-2.ebuild
++++ fixed/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-2.ebuild
+@@ -4,11 +4,3 @@ DESCRIPTION="Ebuild using banned commands"
+ HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+ SLOT="0"
+ LICENSE="BSD"
+-
+-pkg_preinst() {
+-	usermod -s /bin/bash uucp || die
+-}
+-
+-pkg_postrm() {
+-	usermod -s /bin/false uucp || die
+-}
diff --git a/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-2.ebuild b/testdata/repos/standalone/BadCommandsCheck/BannedEapiCommand/BannedEapiCommand-2.ebuild
@@ -0,0 +1,14 @@
+EAPI=6
+
+DESCRIPTION="Ebuild using banned commands"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+SLOT="0"
+LICENSE="BSD"
+
+pkg_preinst() {
+	usermod -s /bin/bash uucp || die
+}
+
+pkg_postrm() {
+	usermod -s /bin/false uucp || die
+}