Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESIDECMS-2873 add matrix CI jobs #1483

Open
wants to merge 11 commits into
base: stable
Choose a base branch
from

Conversation

zspitzer
Copy link
Contributor

@DominicWatson
Copy link
Contributor

I like this concept, though in its current form its not quite ready. I think:

  1. We should update our testbox github image to accept jdk and lucee version arguments (or use an official Ortus action if they've now published some). Then provide the matrix variables to these actions. While the memory info is interesting, I'm not a fan of customising the output here (and it currently breaks the experience of running tests locally)

  2. We need to do more shaping of the workflow, just the test running is needed to be run in a matrix so we should end up with something like:

[ Build dependencies ] -> [[[ Run tests ]]]  -> [ Package & Publish ]
                          JDk 11 & Lucee 5
                          JDk 11 & Lucee 6.1
                          JDk 21 & Lucee 6.1        

Will need to do some digging to see how much of built artifacts can be shared between jobs.

I think all the custom output and memory profile stuff is interesting, but could/should belong in a separate repo owned by Lucee if they want to use Preside as an example build to be testing things against. I imagine this could be done where the repo is pretty much just github actions and pulls down latest Preside to run against?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants