-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarn を pnpm に移行する #250
Open
fsubal
wants to merge
23
commits into
main
Choose a base branch
from
use-pnpm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Yarn を pnpm に移行する #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsubal
force-pushed
the
use-pnpm
branch
2 times, most recently
from
March 28, 2023 15:56
89a4c9c
to
789c822
Compare
fsubal
had a problem deploying
to
preview-channel
March 28, 2023 15:58
— with
GitHub Actions
Failure
fsubal
had a problem deploying
to
preview-channel
March 28, 2023 16:13
— with
GitHub Actions
Failure
fsubal
had a problem deploying
to
preview-channel
March 29, 2023 01:10
— with
GitHub Actions
Failure
fsubal
had a problem deploying
to
preview-channel
March 29, 2023 01:13
— with
GitHub Actions
Failure
fsubal
had a problem deploying
to
preview-channel
March 29, 2023 01:21
— with
GitHub Actions
Failure
mimokmt
had a problem deploying
to
preview-channel
November 8, 2023 06:28
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
ref: #240
Yarn の PnP モードで得られる「本来追加すべき dependencies のチェックが厳密になる」というメリットは pnpm でも得られる。yarn と違ってエディタ向けの特殊対応とかも必要がない。
そして、pnpm の方が OSS で見かけるのでこっちにしたらどうなるか検証したい( next.js のリポジトリも pnpm を使っている )
動作確認環境
CI が通ること、手元でエディタが普通に動くこと、Storybook が起動すること
チェックリスト
不要なチェック項目は消して構いません