Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iphone7 / Iphone8 godray either too bright or completely black #139

Open
Excaa opened this issue Jan 24, 2018 · 14 comments
Open

Iphone7 / Iphone8 godray either too bright or completely black #139

Excaa opened this issue Jan 24, 2018 · 14 comments
Labels

Comments

@Excaa
Copy link

Excaa commented Jan 24, 2018

image

Enabling godray when using iphone 7 and safari causes the bright spots to be much more brighter than they should be. Attached image shows the result of godray on pixi filters demo site.

On iphone 8 the screen goes black.

@bigtimebuddy
Copy link
Member

Merged fix

@bigtimebuddy
Copy link
Member

After merging #140, still getting this on the iPhone 6S
img_1836

@ivanpopelyshev
Copy link
Contributor

And now I dont know what is wrong there.

@finscn
Copy link
Contributor

finscn commented Mar 1, 2018

I can't reproduce this issue on iPhone 7 & 6 (iOS 11.2.6).

@bigtimebuddy @Excaa , Could you try these code in the frag-shader (replace the part of current code):

    vec4 mist = vec4(noise, noise, noise, 1.0) * (1.0 - coord.y);

    vec4 color = min(texture2D(uSampler, vTextureCoord) + mist, 1.0);
    gl_FragColor = color;

@Excaa
Copy link
Author

Excaa commented Mar 5, 2018

@finscn Will do. I'll let you know if that helps after testers have had time to check it. (havent got iphone myself)

@finscn
Copy link
Contributor

finscn commented Mar 5, 2018

@Excaa , please don't update the iOS .
I think if you update iOS to 11.2.6 , maybe there is no this bug, then we can't debug it.

@finscn
Copy link
Contributor

finscn commented Mar 29, 2018

@Excaa , Hi, is there any news ?

@Excaa
Copy link
Author

Excaa commented Mar 31, 2018

I got initial test reports that with iphonex (ios11.2.2), iphone 6+ (11.2.5), iphone 7 (11.0.2) and iphone5s (10.3.3) it works., though after using it in a product havent gotten any reports yet.

Sadly I dont have any ios devices with the problem myself so I have to wait for reports to come from clients testing department and they are pretty booked up.

@DotFreelance
Copy link

I'm also having this problem. iPhone 6s Plus, Safari, iOS 11.3.1

The godrays seem huge, pixelated and perform very slowly. The godray filter, by the way, appears to be fairly slow on its own, even on desktop machines, particularly when the WebGL renderer is set to transparent.

@finscn
Copy link
Contributor

finscn commented May 12, 2018

Hi @DotFreelance , do you only use godrays filter in the demo ?
How do you set the options of the filter ?

@DotFreelance
Copy link

DotFreelance commented May 16, 2018

@finscn I'm using the godray PIXI filter in an application; I've also tried raw, and with the implementation found here: https://codepen.io/alaingalvan/pen/ICasz (which is similar to the PIXI filter implementation). All of them are calculated with the wrong resolution it looks like. It looks to me that the filter doesn't account for devicePixelRatio, maybe, but it's hard to say. If I can manage to figure out the issue and fix it, I'll come up with a PR. Other godray implementations seem to work ok, hopefully we can get this one working nicely, too!

@DotFreelance
Copy link

I can confirm that this problem seems to only exist on newer updates of iOS devices -- no specific device, but any update > 11.2.5 as best as I can tell. It happens in Safari and in Chrome on iOS. It does not appear to affect any of the Android devices we have. For the sake of time, I will have to disable the effect for mobile devices.

@finscn
Copy link
Contributor

finscn commented May 17, 2018

I have iPhone 6 & iPhone 7 with iOS 11.3.1 . But I don't meet this problem.
So strange.

@bigtimebuddy
Copy link
Member

Does this still reproduce for users on newer iOS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants