Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @sindresorhus/tsconfig from 4.0.0 to 5.0.0 #173

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Bump @sindresorhus/tsconfig from 4.0.0 to 5.0.0 #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f05164d
Bump @sindresorhus/tsconfig from 4.0.0 to 5.0.0
dependabot[bot] Nov 1, 2023
ea8ce76
TS bug fixed 🥹
fregante Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"devDependencies": {
"@parcel/config-webextension": "^2.6.2",
"@sindresorhus/tsconfig": "^4.0.0",
"@sindresorhus/tsconfig": "^5.0.0",
"@types/chrome": "^0.0.245",
"@types/tape": "^5.6.1",
"@types/webextension-polyfill": "^0.10.5",
Expand Down
1 change: 0 additions & 1 deletion source/thisTarget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
return true;
}

// TODO: Test this in Jest, outside the browser

Check warning on line 89 in source/thisTarget.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected 'todo' comment: 'TODO: Test this in Jest, outside the...'

Check warning on line 89 in source/thisTarget.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected 'todo' comment: 'TODO: Test this in Jest, outside the...'
export function getActionForMessage(
from: Sender,
message: Message
Expand Down Expand Up @@ -142,7 +142,6 @@
tabDataStatus = "error";
throw new MessengerError(
"Tab registration failed. This page won’t be able to receive messages that require tab information",
// @ts-expect-error TODO: update lib to accept Error#cause
{ cause: error }
);
}
Expand Down
Loading