Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6624: Don't retry sending messages to discarded tabs #6666

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

fregante
Copy link
Contributor

What does this PR do?

Checklist

  • Add tests
  • Designate a primary reviewer: @BLoe

@fregante fregante changed the title Don't retry messanges on discarded tabs #6624: Don't retry sending messages to discarded tabs Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2ab6d92) 70.18% compared to head (aa083d6) 70.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6666   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files        1183     1183           
  Lines       36799    36799           
  Branches     6921     6921           
=======================================
+ Hits        25826    25827    +1     
+ Misses      10973    10972    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fregante fregante merged commit 9000593 into main Oct 17, 2023
13 checks passed
@fregante fregante deleted the F/perf/discarded branch October 17, 2023 01:20
@grahamlangford grahamlangford added this to the 1.8.2 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Deal with discarded tabs
3 participants