#3216 JQ fromdate error gets cut off in page editor

src/background/logging.ts

@@ -19,7 +19,7 @@ import { uuidv4 } from "@/types/helpers";
 import { getRollbar } from "@/telemetry/initRollbar";
 import { MessageContext, SerializedError, UUID } from "@/core";
 import { Except, JsonObject } from "type-fest";
-import { deserializeError, serializeError } from "serialize-error";
+import { deserializeError } from "serialize-error";
 import { DBSchema, openDB } from "idb/with-async-ittr";
 import { isEmpty, once, sortBy } from "lodash";
 import { allowsTrack } from "@/telemetry/dnt";
@@ -32,6 +32,7 @@ import {
   IGNORED_ERROR_PATTERNS,
   isAxiosError,
   isContextError,
+  serializePixiebrixError,
 } from "@/errors";
 import { expectContext, forbidContext } from "@/utils/expectContext";
 import { isAppRequest, selectAbsoluteUrl } from "@/services/requestErrorUtils";
@@ -333,7 +334,7 @@ export async function recordError(
         data,
 
         // Ensure it's serialized
-        error: serializeError(maybeSerializedError),
+        error: serializePixiebrixError(maybeSerializedError as Error),
       }),
     ]);
   } catch (recordError) {

src/blocks/transformers/jq.ts

@@ -22,6 +22,8 @@ import { isNullOrBlank } from "@/utils";
 import { InputValidationError } from "@/blocks/errors";
 import { isErrorObject } from "@/errors";
 
+const jqStacktraceRegexp = /jq: error \(at \<stdin\>:0\): (?<message>.*)/;
+
 export class JQTransformer extends Transformer {
   override async isPure(): Promise<boolean> {
     return true;
@@ -66,13 +68,28 @@ export class JQTransformer extends Transformer {
       // eslint-disable-next-line @typescript-eslint/return-await -- Type is `any`, it throws the rule off
       return await jq.promised.json(input, filter);
     } catch (error) {
-      if (!isErrorObject(error) || !error.message.includes("compile error")) {
+      // The message length check is there because the JQ error message sometimes is cut and if it is we try to parse the stacktrace
+      // See https://github.com/pixiebrix/pixiebrix-extension/issues/3216
+      if (
+        !isErrorObject(error) ||
+        (error.message.length > 13 && !error.message.includes("compile error"))
+      ) {
         throw error;
       }
 
-      const message = error.stack.includes("unexpected $end")
-        ? "Unexpected end of jq filter, are you missing a parentheses, brace, and/or quote mark?"
-        : "Invalid jq filter, see error log for details";
+      let message: string;
+      if (error.stack.includes("unexpected $end")) {
+        message =
+          "Unexpected end of jq filter, are you missing a parentheses, brace, and/or quote mark?";
+      } else {
+        const jqMessageFromStack = jqStacktraceRegexp.exec(error.stack)?.groups
+          ?.message;
+        if (jqMessageFromStack == null) {
+          message = "Invalid jq filter, see error log for details";
+        } else {
+          message = jqMessageFromStack.trim();
+        }
+      }
 
       throw new InputValidationError(
         message,

src/errors.test.ts

@@ -27,11 +27,13 @@ import {
   MultipleElementsFoundError,
   NoElementsFoundError,
   selectError,
+  serializePixiebrixError,
 } from "@/errors";
 import { range } from "lodash";
 import { deserializeError, serializeError } from "serialize-error";
 import { InputValidationError, OutputValidationError } from "@/blocks/errors";
 import { matchesAnyPattern } from "@/utils";
+import { isPlainObject } from "@reduxjs/toolkit";
 
 const TEST_MESSAGE = "Test message";
 
@@ -291,3 +293,22 @@ describe("selectError", () => {
     );
   });
 });
+
+describe("serializatin", () => {
+  test("serializes error cause", () => {
+    const inputValidationError = new InputValidationError(
+      "test input validation error",
+      null,
+      null,
+      []
+    );
+    const contextError = new ContextError("text context error", {
+      cause: inputValidationError,
+    });
+
+    const serializedError = serializePixiebrixError(contextError);
+
+    expect(isPlainObject(serializedError)).toBeTruthy();
+    expect(isPlainObject(serializedError.cause)).toBeTruthy();
+  });
+});

src/errors.ts

@@ -16,7 +16,7 @@
  */
 
 import { MessageContext } from "@/core";
-import { deserializeError, ErrorObject } from "serialize-error";
+import { deserializeError, ErrorObject, serializeError } from "serialize-error";
 import { AxiosError, AxiosResponse } from "axios";
 import { isObject, matchesAnyPattern } from "@/utils";
 import safeJsonStringify from "json-stringify-safe";
@@ -250,6 +250,16 @@ export function isContextError(error: unknown): error is ContextError {
   );
 }
 
+// The serializeError preserves custom properties that effectively means the "cause" is skipped by the serializer
+export function serializePixiebrixError(error: Error): ErrorObject {
+  const serializedError = serializeError(error);
+  if ("cause" in error) {
+    serializedError.cause = serializePixiebrixError(error.cause as Error);
+  }
+
+  return serializedError;
+}
+
 /**
  * Returns true iff the root cause of the error was a CancelError.
  * @param error the error object