Use Messenger for sidebar bricks #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Oct 13, 2021
Comment on lines
+49
to
+55
| registerActionFrame: getMethod("REGISTER_ACTION_FRAME"), | ||
| forwardFrameNotification: getMethod("FORWARD_FRAME_NOTIFICATION", { | ||
| isNotification: true, | ||
| }), | ||
| showActionFrame: getMethod("SHOW_ACTION_FRAME"), | ||
| hideActionFrame: getMethod("HIDE_ACTION_FRAME"), | ||
| }; |
There was a problem hiding this comment.
Test report
Working
- REGISTER_ACTION_FRAME
- SHOW_ACTION_FRAME
- HIDE_ACTION_FRAME
Untested
- FORWARD_FRAME_NOTIFICATION
Can you tell me what I should set up to test this? I have not ported it messenger yet because a couple of key components might be missing
There was a problem hiding this comment.
FORWARD_FRAME_NOTIFICATION is used to pass information from the content script on the main page to the sidebar panel. It's used in many of the methods in actionPanel/native.tsx via calls to renderPanels
The way to test would be:
- Create a sidebar panel using the page editor: e.g., https://docs.pixiebrix.com/tutorial-trello-status-sidebar
- Save it
- Toggle the side bar on/off
- Go to a different page and toggle it on/off
If the messages aren't working you won't see the header for the panel and won't see any panel content on pages where the panel should appear
fregante
commented
Oct 13, 2021
fregante
changed the title
fregante
changed the title
fregante
changed the title
twschiller
approved these changes
Oct 14, 2021
Test report updateWorking
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I replaced sendMessage-based handlers (not
liftBackground)Pretty straightforward, except that it made me question a few things:
Particularly around something I have not touched yet:
forwardWhenReady/RENDER_PANELS_MESSAGE