Bump eslint-config-pixiebrix from 0.27.2 to 0.28.1 (#6632)

* Bump eslint-config-pixiebrix from 0.27.2 to 0.28.1 Bumps [eslint-config-pixiebrix](https://github.com/pixiebrix/eslint-config-pixiebrix) from 0.27.2 to 0.28.1. - [Release notes](https://github.com/pixiebrix/eslint-config-pixiebrix/releases) - [Commits](pixiebrix/eslint-config-pixiebrix@v0.27.2...v0.28.1) --- updated-dependencies: - dependency-name: eslint-config-pixiebrix dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * lint fixes --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Graham Langford <[email protected]>
pixiebrix · Oct 10, 2023 · 9bf6ecd · 9bf6ecd
1 parent b2ec7da
commit 9bf6ecd
Show file tree

Hide file tree

Showing 9 changed files with 537 additions and 99 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -245,7 +245,7 @@
     "css-minimizer-webpack-plugin": "^3.4.1",
     "dotenv": "^16.3.1",
     "eslint": "^8.51.0",
-    "eslint-config-pixiebrix": "^0.27.2",
+    "eslint-config-pixiebrix": "^0.28.1",
     "eslint-config-pixiebrix-extension": "file:./eslint-plugin-pixiebrix-extension",
     "eslint-plugin-pixiebrix-extension": "file:./eslint-plugin-pixiebrix-extension",
     "fake-indexeddb": "^4.0.2",

diff --git a/src/analysis/analysisVisitors/formBrickAnalysis.ts b/src/analysis/analysisVisitors/formBrickAnalysis.ts
@@ -20,6 +20,7 @@ import { type BrickConfig, type BrickPosition } from "@/bricks/types";
 import { type VisitBlockExtra } from "@/bricks/PipelineVisitor";
 import { FORM_MODAL_ID } from "@/pageEditor/fields/FormModalOptions";
 import { AnnotationType } from "@/types/annotationTypes";
+import { PipelineFlavor } from "@/pageEditor/pageEditorTypes";
 
 class FormBrickAnalysis extends AnalysisVisitorABC {
   get id() {
@@ -40,7 +41,7 @@ class FormBrickAnalysis extends AnalysisVisitorABC {
     // The other direction (not placing the renderer form in an action, is already handled by brickTypeAnalysis.ts)
 
     if (
-      extra.pipelineFlavor === "noEffect" &&
+      extra.pipelineFlavor === PipelineFlavor.NoEffect &&
       blockConfig.id === FORM_MODAL_ID
     ) {
       this.annotations.push({

diff --git a/src/background/contentScript.ts b/src/background/contentScript.ts
@@ -123,7 +123,6 @@ export const ensureContentScript = memoizeUntilSettled(
       await pTimeout(ensureContentScriptWithoutTimeout(target, signal), {
         signal,
         milliseconds: timeoutMillis,
-        // eslint-disable-next-line @typescript-eslint/restrict-template-expressions -- known to be a number
         message: `contentScript not ready in ${timeoutMillis}ms`,
       });
 

diff --git a/src/components/fields/schemaFields/widgets/varPopup/menuFilters.ts b/src/components/fields/schemaFields/widgets/varPopup/menuFilters.ts
@@ -40,7 +40,7 @@ export type MenuOptions = Array<[string, UnknownRecord]>;
 export function excludeIntegrationVariables(options: MenuOptions): MenuOptions {
   return options.filter(([source]) => {
     const [kind] = source.split(":");
-    return kind !== KnownSources.SERVICE;
+    return (kind as KnownSources) !== KnownSources.SERVICE;
   });
 }
 

diff --git a/src/contrib/google/sheets/core/types.ts b/src/contrib/google/sheets/core/types.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-redundant-type-constituents -- TODO: The rule is right, but is this used for documentation? */
 /*
  * Copyright (C) 2023 PixieBrix, Inc.
  *
@@ -27,7 +26,7 @@ export interface Doc extends SheetMeta {
 }
 
 export interface Data {
-  action: string;
+  action: google.picker.Action;
   docs: Doc[];
 }
 

diff --git a/src/pageEditor/tabs/editTab/editTabTypes.ts b/src/pageEditor/tabs/editTab/editTabTypes.ts
@@ -48,7 +48,6 @@ export enum RunStatus {
 }
 
 export type BrickNodeContentProps = {
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents -- https://github.com/typescript-eslint/typescript-eslint/issues/5407
   icon?: IconProp | React.ReactNode;
   runStatus?: RunStatus;
   brickLabel: string;

diff --git a/src/pageEditor/tabs/editTab/editorNodes/brickNode/BrickNodeContent.tsx b/src/pageEditor/tabs/editTab/editorNodes/brickNode/BrickNodeContent.tsx
@@ -26,7 +26,6 @@ import {
 } from "@/pageEditor/tabs/editTab/editTabTypes";
 
 function isFontAwesomeIcon(
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents -- https://github.com/typescript-eslint/typescript-eslint/issues/5407
   maybeIcon: IconProp | React.ReactNode
 ): maybeIcon is IconProp {
   return (

diff --git a/src/services/api.ts b/src/services/api.ts
@@ -146,7 +146,7 @@ export const appApi = createApi({
 
           // eslint-disable-next-line @typescript-eslint/no-explicit-any -- `organization.members` is about to be removed
           role: (apiOrganization as any).members?.some(
-            (member: { role: number }) => member.role === UserRole.admin
+            (member: { role: UserRole }) => member.role === UserRole.admin
           )
             ? UserRole.admin
             : UserRole.restricted,