Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] in-ns form #506

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomasmulvaney
Copy link
Member

This is an attempt to address #366

This makes in-ns just a regular function. Things seem to mostly just work, but i had to change some of the tests slightly. I think most of the issues were probably to with the deftest macro. For example the defprotocol inside a test broke unless i put a (in-ns ...) before it. Also I had to wrap some code in eval so it would end up in the foo namespace and not in the pixie.test.test-stdlib namespace.

Ideally we shouldn't have to make the changes I made to the tests. Any thoughts?

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant