[Issue #815]Fix bug/null value of string #824
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whzruc
changed the title
whzruc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Java implementation of StringColumnReader, we need to rewrite the C++ version, with a particular focus on resolving the parsing of null string values. In the new version of DuckDB, there's an issue with the ColumnVector->isNull implementation. To address this and to be compatible with newly added methods like addValue, I've changed the type of isNull from uint8_t* to bool*.
However, there are still remaining bugs:
BufferPool management: There seem to be problems related to how the BufferPool is being handled. This could potentially lead to incorrect memory allocation, deallocation, or data access within the buffer.
Next pxl error?:
When scanning a single pixel (pxl), the result is correct as tested in the new pull request of DuckDB.
But when attempting to read the next pixel, an error related to incorrect string values occurs.
It's suspected that this might be associated with the BufferPool management issue (Bug 1). Further investigation is needed to pinpoint the exact cause and find a proper solution for both bugs.